From: "Michael S. Tsirkin" <mst@redhat.com>
To: wexu@redhat.com
Cc: mjrosato@linux.vnet.ibm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net,stable v4 0/3] vhost: fix a few skb leaks
Date: Fri, 1 Dec 2017 16:47:59 +0200 [thread overview]
Message-ID: <20171201164731-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1512123038-15773-1-git-send-email-wexu@redhat.com>
On Fri, Dec 01, 2017 at 05:10:35AM -0500, wexu@redhat.com wrote:
> From: Wei Xu <wexu@redhat.com>
>
> Matthew found a roughly 40% tcp throughput regression with commit
> c67df11f(vhost_net: try batch dequing from skb array) as discussed
> in the following thread:
> https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html
Series
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> v4:
> - fix zero iov iterator count in tap/tap_do_read()(Jason)
> - don't put tun in case of EBADFD(Jason)
> - Replace msg->msg_control with new 'skb' when calling tun/tap_do_read()
>
> v3:
> - move freeing skb from vhost to tun/tap recvmsg() to not
> confuse the callers.
>
> v2:
> - add Matthew as the reporter, thanks matthew.
> - moving zero headcount check ahead instead of defer consuming skb
> due to jason and mst's comment.
> - add freeing skb in favor of recvmsg() fails.
>
> Wei Xu (3):
> vhost: fix skb leak in handle_rx()
> tun: free skb in early errors
> tap: free skb if flags error
>
> drivers/net/tap.c | 14 ++++++++++----
> drivers/net/tun.c | 24 ++++++++++++++++++------
> drivers/vhost/net.c | 20 ++++++++++----------
> 3 files changed, 38 insertions(+), 20 deletions(-)
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2017-12-01 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 10:10 [PATCH net,stable v4 0/3] vhost: fix a few skb leaks wexu
2017-12-01 10:10 ` [PATCH 1/3] vhost: fix skb leak in handle_rx() wexu
2017-12-01 14:48 ` Michael S. Tsirkin
2017-12-01 10:10 ` [PATCH 2/3] tun: free skb in early errors wexu
2017-12-01 14:48 ` Michael S. Tsirkin
2017-12-01 10:10 ` [PATCH 3/3] tap: free skb if flags error wexu
2017-12-01 14:48 ` Michael S. Tsirkin
2017-12-01 14:47 ` Michael S. Tsirkin [this message]
2017-12-01 14:54 ` [PATCH net,stable v4 0/3] vhost: fix a few skb leaks Matthew Rosato
2017-12-01 14:58 ` Michael S. Tsirkin
2017-12-03 2:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201164731-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).