From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, f.fainelli@gmail.com,
andrew@lunn.ch
Subject: Re: [PATCH net-next 0/2] net: dsa: cross-chip FDB support
Date: Sat, 02 Dec 2017 21:22:00 -0500 (EST) [thread overview]
Message-ID: <20171202.212200.1559874215512257002.davem@davemloft.net> (raw)
In-Reply-To: <20171130175643.14022-1-vivien.didelot@savoirfairelinux.com>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Thu, 30 Nov 2017 12:56:41 -0500
> DSA can have interconnected switches. For instance, the ZII Dev Rev B
> board described in arch/arm/boot/dts/vf610-zii-dev-rev-b.dts has a
> switch fabric composed of 3 switch devices like this:
>
> lan4 lan6
> CPU (eth1) | lan5 | lan7
> | | | | |
> [0 1 2 3 4 6 5]---[6 0 1 2 3 4 5]---[9 0 1 2 3 4 5 6 7 8]
> | | | | | | |
> lan0 | lan2 lan3 lan8 | optical4
> lan1 optical3
>
> One current issue with DSA is cross-chip FDB. If we add a static MAC
> address on lan3, only its parent switch 1 (the one in the middle) will
> be programmed. That is not correct in a cross-chip environment, because
> the DSA ports connecting to switch 1 of adjacent switch 0 (on the left)
> and switch 2 (on the right) must be programmed too.
>
> Without this patchset, a dump of the hardware FDB of switches 0, 1 and 2
> after programming a MAC address on lan3 looks like this (*):
>
> # bridge fdb add 11:22:33:44:55:66 dev lan3
> # cat /sys/kernel/debug/mv88e6xxx/sw*/atu/0 | grep -v FID
> 0 ff:ff:ff:ff:ff:ff MC_STATIC n 0 1 2 3 4 5 6
> 0 11:22:33:44:55:66 MC_STATIC_MGMT_PO n 0 - - - - - -
> 0 ff:ff:ff:ff:ff:ff MC_STATIC n 0 1 2 3 4 5 6
> 0 ff:ff:ff:ff:ff:ff MC_STATIC n 0 1 2 3 4 5 6 7 8 9
>
> With this patchset applied, adjacent DSA ports get programmed too:
>
> # bridge fdb add 11:22:33:44:55:66 dev lan3
> # cat /sys/kernel/debug/mv88e6xxx/sw*/atu/0 | grep -v FID
> 0 11:22:33:44:55:66 MC_STATIC_MGMT_PO n - - - - - 5 -
> 0 ff:ff:ff:ff:ff:ff MC_STATIC n 0 1 2 3 4 5 6
> 0 11:22:33:44:55:66 MC_STATIC_MGMT_PO n 0 - - - - - -
> 0 ff:ff:ff:ff:ff:ff MC_STATIC n 0 1 2 3 4 5 6
> 0 11:22:33:44:55:66 MC_STATIC_MGMT_PO n - - - - - - - - - 9
> 0 ff:ff:ff:ff:ff:ff MC_STATIC n 0 1 2 3 4 5 6 7 8 9
...
Series applied, thanks.
prev parent reply other threads:[~2017-12-03 2:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 17:56 [PATCH net-next 0/2] net: dsa: cross-chip FDB support Vivien Didelot
2017-11-30 17:56 ` [PATCH net-next 1/2] net: dsa: introduce dsa_towards_port helper Vivien Didelot
2017-11-30 17:56 ` [PATCH net-next 2/2] net: dsa: support cross-chip FDB operations Vivien Didelot
2017-12-03 2:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171202.212200.1559874215512257002.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).