netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Solio Sarabia <solio.sarabia@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org,
	"davem@davemloft.net Stephen Hemminger" <sthemmin@microsoft.com>
Subject: Re: [PATCH net-next 0/2] allow setting gso_maximum values
Date: Fri, 1 Dec 2017 17:03:34 -0800	[thread overview]
Message-ID: <20171202010334.GA209@intel.com> (raw)
In-Reply-To: <20171201153001.4170f55d@xeon-e3>

On Fri, Dec 01, 2017 at 03:30:01PM -0800, Stephen Hemminger wrote:
> On Fri,  1 Dec 2017 12:11:56 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> > This is another way of addressing the GSO maximum performance issues for
> > containers on Azure. What happens is that the underlying infrastructure uses
> > a overlay network such that GSO packets over 64K - vlan header end up cause
> > either guest or host to have do expensive software copy and fragmentation.
> > 
> > The netvsc driver reports GSO maximum settings correctly, the issue
> > is that containers on veth devices still have the larger settings.
> > One solution that was examined was propogating the values back
> > through the bridge device, but this does not work for cases where
> > virtual container network is done on L3.
> > 
> > This patch set punts the problem to the orchestration layer that sets
> > up the container network. It also enables other virtual devices
> > to have configurable settings for GSO maximum.
> > 
> > Stephen Hemminger (2):
> >   rtnetlink: allow GSO maximums to be passed to device
> >   veth: allow configuring GSO maximums
> > 
> >  drivers/net/veth.c   | 20 ++++++++++++++++++++
> >  net/core/rtnetlink.c |  2 ++
> >  2 files changed, 22 insertions(+)
> > 
> 
> I would like a confirmation from Intel that is doing Docker testing
> that this works for them before merging.

This change and its iproute2 counterpart allow creating veth pairs with
specific gso_max{size,segs}. Thanks.

However, the docker code that sets up veth pairis is go-compiled in
their libnetwork. End-users won't be able to tweak gso settings at veth
creation. In this case, we would need to add ioctl (ip/iplink.c:do_set)
support to allow changes after veth is created.

  reply	other threads:[~2017-12-02  1:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 20:11 [PATCH net-next 0/2] allow setting gso_maximum values Stephen Hemminger
2017-12-01 20:11 ` [PATCH net-next 1/2] rtnetlink: allow GSO maximums to be passed to device Stephen Hemminger
2017-12-01 20:11 ` [PATCH net-next 2/2] veth: allow configuring GSO maximums Stephen Hemminger
2017-12-04  2:43   ` David Ahern
2017-12-05  0:03   ` Cong Wang
2017-12-05  1:04     ` Eric Dumazet
2017-12-01 23:30 ` [PATCH net-next 0/2] allow setting gso_maximum values Stephen Hemminger
2017-12-02  1:03   ` Solio Sarabia [this message]
2017-12-04 15:40   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171202010334.GA209@intel.com \
    --to=solio.sarabia@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).