From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type
 build error in RHEL 6.8
Date: Sat, 2 Dec 2017 10:28:33 +0200
Message-ID: <20171202082833.GF8126@mtr-leonro.local>
References: <20171201110451.25392-1-leon@kernel.org>
 <20171201084807.0ccfcc86@xeon-e3>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="CGDBiGfvSTbxKZlW"
Cc: netdev@vger.kernel.org, Riad Abo Raed <riada@mellanox.com>,
        Guy Ergas <guye@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:43526 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751285AbdLBI2h (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 2 Dec 2017 03:28:37 -0500
Content-Disposition: inline
In-Reply-To: <20171201084807.0ccfcc86@xeon-e3>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--CGDBiGfvSTbxKZlW
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 01, 2017 at 08:48:07AM -0800, Stephen Hemminger wrote:
> On Fri,  1 Dec 2017 13:04:51 +0200
> Leon Romanovsky <leon@kernel.org> wrote:
>
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Add asm/posix_types.h header file to the list of needed includes,
> > because the headers files in RHEL 6.8 are too old and doesn't
> > have declaration of __kernel_long_t.
> >
> > In file included from ../include/uapi/linux/kernel.h:5,
> >                  from ../include/uapi/linux/netfilter/x_tables.h:4,
> >                  from ../include/xtables.h:20,
> >                  from em_ipset.c:26:
> > ../include/uapi/linux/sysinfo.h:9: error: expected specifier-qualifier-=
list before =E2=80=98__kernel_long_t=E2=80=99
> >
> > Cc: Riad Abo Raed <riada@mellanox.com>
> > Cc: Guy Ergas <guye@mellanox.com>
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
>
> I see the problem, but the solution of dragging in posix_types.h
> would be too much of a long term maintenance issue.
> All the headers in uapi are regularly generated from upstream
> kernel headers; I don't want to start making exceptions.
>
> Is it just the xtables stuff (which has always been problematic)?

Yes, both failures are related to xtables. And this wass my naive approach =
to
solve first one, the second mentioned in the original commit log
(missing xtables-version.h) is more harder to fix.

Will it work if I test in configure script the existence of __kernel_long_t
and fallback to xt-internal.h?

Thanks

--CGDBiGfvSTbxKZlW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAloiZDAACgkQ5GN7iDZy
WKe5uQ//UlQutog5Ifs49qdhSp3HRGKWWUR1xOsnfb1iOpyFxVQh4e47cN37ZEqd
UXBISu/yNeyOdeTzZo6PMZYPsZqnP3HpCfqKj0bxrGCO09fF8sYlNFbJ8mm9gHDK
cdidXw4Zd1Eb0+mTNgomzLSe1d/+HSmsh00mqJGTyAuOxb0HK2dtx85Mn7HfjD+C
hPbCmtqGWkwaUSw7QaRpI9o1HkMgv4lsxrCoBJg02f0V6CAdkPJIkuRJcQXIrz5D
goQlxf916puZ57bEbhesBF3ciymmC2yGyoCG/iDAgd2teee5uWFBF+hjbsT4VVpm
LteKfRg+NevJPK+9Kl5JNp6F2BY2EuQzSRT5fFkfna3GaXNL7lZcJEAXGNh/JINP
KW8J/AlJhHBm6Js7ymJwTm/GQZVJ/tw0RV/+w57YCMZV2xJeWAqjA8i6Negbmegq
viyRol2hHTHVF8M3W+7Udk/WFJDyyDNW2chx8Y3BHBPY9BtezmSMCAwIs4B5Vauj
gwOcX8FTMel5J0TKI2QZ7KxxBdUJoTApiw2PdgWorHY9xMw9MJ9LWwnl4KepEa66
kqOa50hD2Kk3HTU+0K9KoaD+pYDhKYFJngA+r3ng/tJROC686lsDKZzAWE5DrzHN
J4QXNb8sPkIeJFpTgy3Ezip2tE+rkR/8PjMKkpF3hT5YB0vTzeQ=
=UryH
-----END PGP SIGNATURE-----

--CGDBiGfvSTbxKZlW--