From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 1/3] iio: trigger: Fix platform_get_irq's error checking Date: Sat, 2 Dec 2017 12:22:41 +0000 Message-ID: <20171202122241.54c9d376@archlinux> References: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> <1512056616-21065-2-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, Michael.Hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arvind Yadav Return-path: In-Reply-To: <1512056616-21065-2-git-send-email-arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, 30 Nov 2017 21:13:34 +0530 Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav Applied to the togreg branch of iio.git. This is probably just a theoretical problem as obviously the blackfin trigger only runs on blackfin boards and I assume they only return 0. Anyhow, nothing wrong with tidying it up as might possible get cut and paste to somewhere it does matter in future! Jonathan > --- > drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c > index d80dcf8..f389f5c 100644 > --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c > +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c > @@ -187,9 +187,9 @@ static int iio_bfin_tmr_trigger_probe(struct platform_device *pdev) > return -ENOMEM; > > st->irq = platform_get_irq(pdev, 0); > - if (!st->irq) { > + if (st->irq < 0) { > dev_err(&pdev->dev, "No IRQs specified"); > - return -ENODEV; > + return st->irq; > } > > ret = iio_bfin_tmr_get_number(st->irq);