From: David Miller <davem@davemloft.net>
To: lars.persson@axis.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, larper@axis.com
Subject: Re: [PATCH net] stmmac: reset last TSO segment size after device open
Date: Sun, 03 Dec 2017 09:48:25 -0500 (EST) [thread overview]
Message-ID: <20171203.094825.2018066401141815227.davem@davemloft.net> (raw)
In-Reply-To: <20171201101244.16675-1-larper@axis.com>
From: Lars Persson <lars.persson@axis.com>
Date: Fri, 1 Dec 2017 11:12:44 +0100
> The mss variable tracks the last max segment size sent to the TSO
> engine. We do not update the hardware as long as we receive skb:s with
> the same value in gso_size.
>
> During a network device down/up cycle (mapped to stmmac_release() and
> stmmac_open() callbacks) we issue a reset to the hardware and it
> forgets the setting for mss. However we did not zero out our mss
> variable so the next transmission of a gso packet happens with an
> undefined hardware setting.
>
> This triggers a hang in the TSO engine and eventuelly the netdev
> watchdog will bark.
>
> Fixes: f748be531d70 ("stmmac: support new GMAC4")
> Signed-off-by: Lars Persson <larper@axis.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2017-12-03 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 10:12 [PATCH net] stmmac: reset last TSO segment size after device open Lars Persson
2017-12-03 14:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203.094825.2018066401141815227.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=larper@axis.com \
--cc=lars.persson@axis.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).