From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] rxrpc: Use correct netns source in
 rxrpc_release_sock()
Date: Sun, 03 Dec 2017 10:05:36 -0500 (EST)
Message-ID: <20171203.100536.629501852369881483.davem@davemloft.net>
References: <151212659389.11212.9262287438388463076.stgit@warthog.procyon.org.uk>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org,
        linux-kernel@vger.kernel.org
To: dhowells@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:36046 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751723AbdLCPFi (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 3 Dec 2017 10:05:38 -0500
In-Reply-To: <151212659389.11212.9262287438388463076.stgit@warthog.procyon.org.uk>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: David Howells <dhowells@redhat.com>
Date: Fri, 01 Dec 2017 11:09:53 +0000

> In rxrpc_release_sock() there may be no rx->local value to access, so we
> can't unconditionally follow it to the rxrpc network namespace information
> to poke the connection reapers.
> 
> Instead, use the socket's namespace pointer to find the namespace.
> 
> This unfixed code causes the following static checker warning:
> 
> 	net/rxrpc/af_rxrpc.c:898 rxrpc_release_sock()
> 	error: we previously assumed 'rx->local' could be null (see line 887)
> 
> Fixes: 3d18cbb7fd0c ("rxrpc: Fix conn expiry timers")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied.