From: David Miller <davem@davemloft.net>
To: kafai@fb.com
Cc: netdev@vger.kernel.org, edumazet@google.com, kernel-team@fb.com
Subject: Re: [PATCH v2 net-next 0/4] tcp: Add a 2nd listener hashtable (port+addr)
Date: Sun, 03 Dec 2017 10:18:43 -0500 (EST) [thread overview]
Message-ID: <20171203.101843.632762941894705268.davem@davemloft.net> (raw)
In-Reply-To: <20171201205232.3012584-1-kafai@fb.com>
From: Martin KaFai Lau <kafai@fb.com>
Date: Fri, 1 Dec 2017 12:52:28 -0800
> This patch set adds a 2nd listener hashtable. It is to resolve
> the performance issue when a process is listening at many IP
> addresses with the same port (e.g. [IP1]:443, [IP2]:443... [IPN]:443)
>
> v2:
> - Move the new lhash2 and lhash2_mask before the existing
> listening_hash to avoid adding another cacheline
> to inet_hashinfo (Suggested by Eric Dumazet, Thanks!)
> - I take this chance to plug an existing 4 bytes hole while
> adding 'unsigned int lhash2_mask'.
> - Add some comments about lhash2 in inet_hashtables.h
Nice work, series applied.
prev parent reply other threads:[~2017-12-03 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 20:52 [PATCH v2 net-next 0/4] tcp: Add a 2nd listener hashtable (port+addr) Martin KaFai Lau
2017-12-01 20:52 ` [PATCH v2 net-next 1/4] inet: Add a count to struct inet_listen_hashbucket Martin KaFai Lau
2017-12-01 20:52 ` [PATCH v2 net-next 2/4] udp: Move udp[46]_portaddr_hash() to net/ip[v6].h Martin KaFai Lau
2017-12-01 20:52 ` [PATCH v2 net-next 3/4] inet: Add a 2nd listener hashtable (port+addr) Martin KaFai Lau
2017-12-01 22:24 ` Eric Dumazet
2017-12-01 20:52 ` [PATCH v2 net-next 4/4] tcp: Enable 2nd listener hashtable in TCP Martin KaFai Lau
2017-12-03 15:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203.101843.632762941894705268.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).