From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net-next 0/4] tcp: Add a 2nd listener hashtable (port+addr) Date: Sun, 03 Dec 2017 10:18:43 -0500 (EST) Message-ID: <20171203.101843.632762941894705268.davem@davemloft.net> References: <20171201205232.3012584-1-kafai@fb.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, edumazet@google.com, kernel-team@fb.com To: kafai@fb.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:36294 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbdLCPSp (ORCPT ); Sun, 3 Dec 2017 10:18:45 -0500 In-Reply-To: <20171201205232.3012584-1-kafai@fb.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Martin KaFai Lau Date: Fri, 1 Dec 2017 12:52:28 -0800 > This patch set adds a 2nd listener hashtable. It is to resolve > the performance issue when a process is listening at many IP > addresses with the same port (e.g. [IP1]:443, [IP2]:443... [IPN]:443) > > v2: > - Move the new lhash2 and lhash2_mask before the existing > listening_hash to avoid adding another cacheline > to inet_hashinfo (Suggested by Eric Dumazet, Thanks!) > - I take this chance to plug an existing 4 bytes hole while > adding 'unsigned int lhash2_mask'. > - Add some comments about lhash2 in inet_hashtables.h Nice work, series applied.