From: David Miller <davem@davemloft.net>
To: shli@kernel.org
Cc: netdev@vger.kernel.org, kafai@fb.com, eric.dumazet@gmail.com,
flo@fourcot.fr, xiyou.wangcong@gmail.com, tom@herbertland.com,
shli@fb.com
Subject: Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash
Date: Sun, 03 Dec 2017 10:38:01 -0500 (EST) [thread overview]
Message-ID: <20171203.103801.90553633657825548.davem@davemloft.net> (raw)
In-Reply-To: <e52c22258a70b5b4adfdc96362992f8a285a9a3c.1512161808.git.shli@fb.com>
From: Shaohua Li <shli@kernel.org>
Date: Fri, 1 Dec 2017 13:00:43 -0800
> This causes our router doesn't correctly close tcp connection.
Then please fix your router.
How many times do I have to say this... The flowlabel is not part of
the socket connection identity, therefore you cannot use it for
connection state.
The more of these kinds of patches with this kind of nonsense in the
commit message I let into the tree the more this illusion of the
flowlabel meaning something on the connection level is made to seem
like reality.
Can we please stop pretending that the flowlabel is part of the
saddr/sport/daddr/dport socket identity? Please???
I don't mind the flowlabel being set correctly, but your justification
stinks.
next prev parent reply other threads:[~2017-12-03 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 21:00 [PATCH net-next V2 0/2] net: fix flowlabel inconsistency in reset packet Shaohua Li
2017-12-01 21:00 ` [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash Shaohua Li
2017-12-01 21:15 ` Tom Herbert
2017-12-03 15:38 ` David Miller [this message]
2017-12-03 16:02 ` Tom Herbert
2017-12-01 21:00 ` [PATCH net-next V2 2/2] net-next: copy user configured flowlabel to reset packet Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203.103801.90553633657825548.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=flo@fourcot.fr \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).