From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash Date: Sun, 03 Dec 2017 10:38:01 -0500 (EST) Message-ID: <20171203.103801.90553633657825548.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kafai@fb.com, eric.dumazet@gmail.com, flo@fourcot.fr, xiyou.wangcong@gmail.com, tom@herbertland.com, shli@fb.com To: shli@kernel.org Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:36436 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbdLCPiD (ORCPT ); Sun, 3 Dec 2017 10:38:03 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Shaohua Li Date: Fri, 1 Dec 2017 13:00:43 -0800 > This causes our router doesn't correctly close tcp connection. Then please fix your router. How many times do I have to say this... The flowlabel is not part of the socket connection identity, therefore you cannot use it for connection state. The more of these kinds of patches with this kind of nonsense in the commit message I let into the tree the more this illusion of the flowlabel meaning something on the connection level is made to seem like reality. Can we please stop pretending that the flowlabel is part of the saddr/sport/daddr/dport socket identity? Please??? I don't mind the flowlabel being set correctly, but your justification stinks.