From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next] netlink: optimize err assignment
Date: Sun, 03 Dec 2017 11:22:00 -0500 (EST)
Message-ID: <20171203.112200.2205442818284347522.davem@davemloft.net>
References: <1512306654-17546-1-git-send-email-cugyly@163.com>
        <1512314409.19682.51.camel@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Cc: cugyly@163.com, netdev@vger.kernel.org,
        Linyu.Yuan@alcatel-sbell.com.cn
To: eric.dumazet@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:36870 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751821AbdLCQWD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 3 Dec 2017 11:22:03 -0500
In-Reply-To: <1512314409.19682.51.camel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 03 Dec 2017 07:20:09 -0800

> On Sun, 2017-12-03 at 21:10 +0800, yuan linyu wrote:
>> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>> 
>> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>> ---
>> v2: fix kbuild test warning
>> ---
>>  net/netlink/af_netlink.c | 52 ++++++++++++++++++++----------------
>> ------------
>>  1 file changed, 22 insertions(+), 30 deletions(-)
>> 
> 
> I see no reason why we should accept this code churn.
> 
> This kind of change makes future fix backports harder.

I agree, and I've been trying to discourage these "improvements"
as much as possible.