From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Biggers <ebiggers3@gmail.com>
Subject: Re: kernel BUG at net/key/af_key.c:LINE!
Date: Sun, 3 Dec 2017 12:28:20 -0800
Message-ID: <20171203202820.GE844@zzz.localdomain>
References: <001a114a958ce46160055c4c4f66@google.com>
 <CACT4Y+b9+1AAJk5Jxddae5okBXo9oaKu0m8gzbgyEnzGByY1hg@mail.gmail.com>
 <20171108074742.GA28177@gondor.apana.org.au>
 <CACT4Y+a_0grrUjrovW=0=0UPkH3pE_HpncDc3uBzwR_YtDURPA@mail.gmail.com>
 <20171109113857.GA15280@gondor.apana.org.au>
 <20171110020459.GA22329@gondor.apana.org.au>
 <20171110021145.GB22329@gondor.apana.org.au>
 <20171110023038.GA22532@gondor.apana.org.au>
 <20171110031406.GA22823@gondor.apana.org.au>
 <20171115112919.GT11292@secunet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
        Dmitry Vyukov <dvyukov@google.com>,
        syzbot
        <bot+413384116f7f7dab7903d54c53fc4af6a4441965@syzkaller.appspotmail.com>,
        David Miller <davem@davemloft.net>,
        LKML <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>, syzkaller-bugs@googlegroups.com
To: Steffen Klassert <steffen.klassert@secunet.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f54.google.com ([74.125.83.54]:43133 "EHLO
        mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751211AbdLCU2X (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 3 Dec 2017 15:28:23 -0500
Content-Disposition: inline
In-Reply-To: <20171115112919.GT11292@secunet.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Nov 15, 2017 at 12:29:19PM +0100, Steffen Klassert wrote:
> On Fri, Nov 10, 2017 at 02:14:06PM +1100, Herbert Xu wrote:
> > On Fri, Nov 10, 2017 at 01:30:38PM +1100, Herbert Xu wrote:
> > > 
> > > I found the problem.  This crap is coming from clone_policy.  Now
> > > let me where this code came from.
> > 
> > ---8<---
> > Subject: xfrm: Copy policy family in clone_policy
> > 
> > The syzbot found an ancient bug in the IPsec code.  When we cloned
> > a socket policy (for example, for a child TCP socket derived from a
> > listening socket), we did not copy the family field.  This results
> > in a live policy with a zero family field.  This triggers a BUG_ON
> > check in the af_key code when the cloned policy is retrieved.
> > 
> > This patch fixes it by copying the family field over.
> > 
> > Reported-by: syzbot <syzkaller@googlegroups.com>
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> Patch applied, thanks Herbert!

And to tell the bot what fixes this:

#syz fix: xfrm: Copy policy family in clone_policy

Also, does this fix need to go to stable?  The commit doesn't have Cc: stable.