From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next resubmit 1/2] net: phy: core: remove now uneeded disabling of interrupts Date: Mon, 04 Dec 2017 10:24:17 -0500 (EST) Message-ID: <20171204.102417.1919875184945871383.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, ard.biesheuvel@linaro.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:48440 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbdLDPYY (ORCPT ); Mon, 4 Dec 2017 10:24:24 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Thu, 30 Nov 2017 23:55:15 +0100 > After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from > sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow > some simplification" all relevant code pieces run in process context > anyway and I don't think we need the disabling of interrupts any longer. > > Interestingly enough, latter commit already removed the comment > explaining why interrupts need to be temporarily disabled. > > On my system phy interrupt mode works fine with this patch. > However I may miss something, especially in the context of shared phy > interrupts, therefore I'd appreciate if more people could test this. > > Signed-off-by: Heiner Kallweit > Acked-by: Ard Biesheuvel Ok, applied. But if this causes regressions I'm reverting.