From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next resubmit 2/2] net: phy: core: don't disable
 device interrupts in phy_change
Date: Mon, 04 Dec 2017 10:24:39 -0500 (EST)
Message-ID: <20171204.102439.2288357008626128786.davem@davemloft.net>
References: <ba11e1ae-dc21-e036-f918-1ed44c92a424@gmail.com>
        <c5db9f65-bbbc-65b3-f2d9-6be2872ef5e8@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org,
        ard.biesheuvel@linaro.org
To: hkallweit1@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:48448 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751463AbdLDPYl (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 4 Dec 2017 10:24:41 -0500
In-Reply-To: <c5db9f65-bbbc-65b3-f2d9-6be2872ef5e8@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 30 Nov 2017 23:57:00 +0100

> If state is not PHY_HALTED I see no need to temporarily disable
> interrupts on the device. As long as the current interrupt isn't acked
> on the device no new interrupt can happen anyway.
> 
> In addition remove a unneeded enabling of interrupts in the state
> machine when handling state PHY_CHANGELINK.
> 
> Tested on a Odroid-C2 with RTL8211F phy in interrupt mode.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Also applied, and again if this regresses things I'm reverting.