From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Simon Horman" <horms+renesas@verge.net.au>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available
Date: Mon, 4 Dec 2017 20:25:28 +0100 [thread overview]
Message-ID: <20171204192528.GB12805@lunn.ch> (raw)
In-Reply-To: <018f1129-826b-ecd7-9b71-b720706aa930@cogentembedded.com>
> >diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> >index db72d13cebb9..0074c5998481 100644
> >--- a/drivers/net/ethernet/renesas/sh_eth.c
> >+++ b/drivers/net/ethernet/renesas/sh_eth.c
> >@@ -1892,6 +1892,11 @@ static int sh_eth_phy_init(struct net_device *ndev)
> > return PTR_ERR(phydev);
> > }
> >+ /* mask with MAC supported features */
> >+ if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
> >+ phydev->supported &= PHY_BASIC_FEATURES;
> >+ phydev->advertising = phydev->supported;
> >+
>
> Um, looking at this again, I think we have phy_set_max_speed() for that
> kind of stuff now...
Ah, yes. I forgot about that.
Thomas, can you make a v2?
Andrew
prev parent reply other threads:[~2017-12-04 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 14:13 [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available Thomas Petazzoni
2017-12-04 15:09 ` Andrew Lunn
2017-12-04 16:06 ` Sergei Shtylyov
2017-12-04 17:42 ` Sergei Shtylyov
2017-12-04 19:25 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204192528.GB12805@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).