* [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available
@ 2017-12-04 14:13 Thomas Petazzoni
2017-12-04 15:09 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2017-12-04 14:13 UTC (permalink / raw)
To: David S. Miller, Sergei Shtylyov, Niklas Söderlund,
Geert Uytterhoeven, Simon Horman
Cc: netdev, linux-renesas-soc, Thomas Petazzoni
Not all variants of the sh_eth hardware have Gigabit
support. Unfortunately, the current driver doesn't update
phydev->supported depending on the MAC capabilities. Due to this, if
you have a Gigabit capable PHY, the PHY will advertise its Gigabit
capability and establish a link at 1Gbit/s, even though the MAC
doesn't support it.
In order to avoid this, we mark phydev->supported if we're running a
non-Gigabit capable hardware.
Tested on a SH7786 platform, with a Gigabit PHY.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index db72d13cebb9..0074c5998481 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -1892,6 +1892,11 @@ static int sh_eth_phy_init(struct net_device *ndev)
return PTR_ERR(phydev);
}
+ /* mask with MAC supported features */
+ if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
+ phydev->supported &= PHY_BASIC_FEATURES;
+ phydev->advertising = phydev->supported;
+
phy_attached_info(phydev);
return 0;
--
2.13.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available
2017-12-04 14:13 [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available Thomas Petazzoni
@ 2017-12-04 15:09 ` Andrew Lunn
2017-12-04 16:06 ` Sergei Shtylyov
2017-12-04 17:42 ` Sergei Shtylyov
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2017-12-04 15:09 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: David S. Miller, Sergei Shtylyov, Niklas Söderlund,
Geert Uytterhoeven, Simon Horman, netdev, linux-renesas-soc
On Mon, Dec 04, 2017 at 03:13:46PM +0100, Thomas Petazzoni wrote:
> Not all variants of the sh_eth hardware have Gigabit
> support. Unfortunately, the current driver doesn't update
> phydev->supported depending on the MAC capabilities. Due to this, if
> you have a Gigabit capable PHY, the PHY will advertise its Gigabit
> capability and establish a link at 1Gbit/s, even though the MAC
> doesn't support it.
>
> In order to avoid this, we mark phydev->supported if we're running a
> non-Gigabit capable hardware.
>
> Tested on a SH7786 platform, with a Gigabit PHY.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available
2017-12-04 14:13 [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available Thomas Petazzoni
2017-12-04 15:09 ` Andrew Lunn
@ 2017-12-04 16:06 ` Sergei Shtylyov
2017-12-04 17:42 ` Sergei Shtylyov
2 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2017-12-04 16:06 UTC (permalink / raw)
To: Thomas Petazzoni, David S. Miller, Niklas Söderlund,
Geert Uytterhoeven, Simon Horman
Cc: netdev, linux-renesas-soc
Hello!
On 12/04/2017 05:13 PM, Thomas Petazzoni wrote:
> Not all variants of the sh_eth hardware have Gigabit
> support. Unfortunately, the current driver doesn't update
> phydev->supported depending on the MAC capabilities. Due to this, if
> you have a Gigabit capable PHY, the PHY will advertise its Gigabit
> capability and establish a link at 1Gbit/s, even though the MAC
> doesn't support it.
>
> In order to avoid this, we mark phydev->supported if we're running a
> non-Gigabit capable hardware.
I guess this (being a fix) was targeted to net.git?
> Tested on a SH7786 platform, with a Gigabit PHY.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
[...]
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available
2017-12-04 14:13 [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available Thomas Petazzoni
2017-12-04 15:09 ` Andrew Lunn
2017-12-04 16:06 ` Sergei Shtylyov
@ 2017-12-04 17:42 ` Sergei Shtylyov
2017-12-04 19:25 ` Andrew Lunn
2 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2017-12-04 17:42 UTC (permalink / raw)
To: Thomas Petazzoni, David S. Miller, Niklas Söderlund,
Geert Uytterhoeven, Simon Horman
Cc: netdev, linux-renesas-soc
On 12/04/2017 05:13 PM, Thomas Petazzoni wrote:
> Not all variants of the sh_eth hardware have Gigabit
> support. Unfortunately, the current driver doesn't update
> phydev->supported depending on the MAC capabilities. Due to this, if
> you have a Gigabit capable PHY, the PHY will advertise its Gigabit
> capability and establish a link at 1Gbit/s, even though the MAC
> doesn't support it.
>
> In order to avoid this, we mark phydev->supported if we're running a
> non-Gigabit capable hardware.
>
> Tested on a SH7786 platform, with a Gigabit PHY.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index db72d13cebb9..0074c5998481 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1892,6 +1892,11 @@ static int sh_eth_phy_init(struct net_device *ndev)
> return PTR_ERR(phydev);
> }
>
> + /* mask with MAC supported features */
> + if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
> + phydev->supported &= PHY_BASIC_FEATURES;
> + phydev->advertising = phydev->supported;
> +
Um, looking at this again, I think we have phy_set_max_speed() for that
kind of stuff now...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available
2017-12-04 17:42 ` Sergei Shtylyov
@ 2017-12-04 19:25 ` Andrew Lunn
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2017-12-04 19:25 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Thomas Petazzoni, David S. Miller, Niklas Söderlund,
Geert Uytterhoeven, Simon Horman, netdev, linux-renesas-soc
> >diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> >index db72d13cebb9..0074c5998481 100644
> >--- a/drivers/net/ethernet/renesas/sh_eth.c
> >+++ b/drivers/net/ethernet/renesas/sh_eth.c
> >@@ -1892,6 +1892,11 @@ static int sh_eth_phy_init(struct net_device *ndev)
> > return PTR_ERR(phydev);
> > }
> >+ /* mask with MAC supported features */
> >+ if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
> >+ phydev->supported &= PHY_BASIC_FEATURES;
> >+ phydev->advertising = phydev->supported;
> >+
>
> Um, looking at this again, I think we have phy_set_max_speed() for that
> kind of stuff now...
Ah, yes. I forgot about that.
Thomas, can you make a v2?
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-04 19:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-04 14:13 [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available Thomas Petazzoni
2017-12-04 15:09 ` Andrew Lunn
2017-12-04 16:06 ` Sergei Shtylyov
2017-12-04 17:42 ` Sergei Shtylyov
2017-12-04 19:25 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).