From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
pieter.jansenvanvuuren@netronome.com
Subject: Re: [PATCH net] nfp: fix port stats for mac representors
Date: Tue, 05 Dec 2017 11:30:06 -0500 (EST) [thread overview]
Message-ID: <20171205.113006.1417740598020175760.davem@davemloft.net> (raw)
In-Reply-To: <CAJpBn1x_-oO4_fesjtr5Le7Ooma7ptLcQNqC6KP0Y-2bFZ2rdA@mail.gmail.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Sat, 2 Dec 2017 02:03:31 -0800
> On Fri, Dec 1, 2017 at 9:37 PM, Jakub Kicinski
> <jakub.kicinski@netronome.com> wrote:
>> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
>>
>> Previously we swapped the tx_packets, tx_bytes and tx_dropped counters
>> with rx_packets, rx_bytes and rx_dropped counters, respectively. This
>> behaviour is correct and expected for VF representors but it should not
>> be swapped for physical port mac representors.
>
> Ah, I forgot to point the finger. Should I repost?
>
> Fixes: eadfa4c3be99 ("nfp: add stats and xmit helpers for representors")
I added this to the commit message, thanks.
next prev parent reply other threads:[~2017-12-05 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 5:37 [PATCH net] nfp: fix port stats for mac representors Jakub Kicinski
2017-12-02 10:03 ` Jakub Kicinski
2017-12-05 16:30 ` David Miller [this message]
2017-12-05 16:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205.113006.1417740598020175760.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox