From: David Miller <davem@davemloft.net>
To: michael.chan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW
Date: Tue, 05 Dec 2017 14:31:39 -0500 (EST) [thread overview]
Message-ID: <20171205.143139.2139801110634773125.davem@davemloft.net> (raw)
In-Reply-To: <1512385967-32339-1-git-send-email-michael.chan@broadcom.com>
From: Michael Chan <michael.chan@broadcom.com>
Date: Mon, 4 Dec 2017 06:12:43 -0500
> Introduce NETIF_F_GRO_HW feature flag and convert drivers that support
> hardware GRO to use the flag.
So I think we should continue ahead with NETIF_F_GRO_HW.
LRO, even if it were in some way more appropriate, has so many stigmas
attached to it. And if you look around the internet, articles say to
turn it off for this reason or that due to the information loss LRO
creates.
The only thing unresolved is how to manage the situation where a
bond or bridge has a mixture of LRO and GRO_HW devices attached,
and Michael said he would look into it.
Thanks.
prev parent reply other threads:[~2017-12-05 19:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 11:12 [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW Michael Chan
2017-12-04 11:12 ` [PATCH net-next 1/4] net: " Michael Chan
2017-12-04 16:30 ` Or Gerlitz
2017-12-04 16:47 ` Alexander Duyck
2017-12-04 18:23 ` Michael Chan
2017-12-04 18:43 ` Alexander Duyck
2017-12-04 18:59 ` David Miller
2017-12-04 19:24 ` Alexander Duyck
2017-12-04 19:26 ` Eric Dumazet
2017-12-04 19:36 ` Alexander Duyck
2017-12-04 19:52 ` Michael Chan
2017-12-04 20:58 ` Alexander Duyck
2017-12-04 23:05 ` Michael Chan
2017-12-04 22:15 ` Yuval Mintz
2017-12-04 22:31 ` Michael Chan
2017-12-04 11:12 ` [PATCH net-next 2/4] bnxt_en: Use NETIF_F_GRO_HW Michael Chan
2017-12-04 16:35 ` Or Gerlitz
2017-12-04 18:11 ` Michael Chan
2017-12-04 21:06 ` Or Gerlitz
2017-12-04 22:00 ` Eric Dumazet
2017-12-05 0:07 ` Michael Chan
2017-12-05 18:10 ` Marcelo Ricardo Leitner
2017-12-06 21:04 ` Michael Chan
2017-12-04 11:12 ` [PATCH net-next 3/4] bnx2x: " Michael Chan
2017-12-04 11:12 ` [PATCH net-next 4/4] qede: " Michael Chan
2017-12-04 21:48 ` Yuval Mintz
2017-12-04 22:45 ` Michael Chan
2017-12-05 12:32 ` Chopra, Manish
2017-12-05 17:13 ` Michael Chan
2017-12-04 11:38 ` [PATCH net-next 0/4] Introduce NETIF_F_GRO_HW Elior, Ariel
2017-12-05 19:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205.143139.2139801110634773125.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).