netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: thomas.petazzoni@free-electrons.com
Cc: sergei.shtylyov@cogentembedded.com,
	niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be,
	horms+renesas@verge.net.au, netdev@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 0/2] net: sh_eth: add support for SH7786 and big-endian
Date: Tue, 05 Dec 2017 14:44:05 -0500 (EST)	[thread overview]
Message-ID: <20171205.144405.531451693140949867.davem@davemloft.net> (raw)
In-Reply-To: <20171204141744.18599-1-thomas.petazzoni@free-electrons.com>

From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Mon,  4 Dec 2017 15:17:42 +0100

> I've recently been working on an SH7786 based platform, which uses the
> sh_eth network controller. One peculiarity of my setup is that the CPU
> is configured big-endian (even though little-endian is more
> traditional in the Linux SuperH world), and the sh_eth driver was not
> ready for this.
> 
> The first patch simply adds the sh_eth_cpu_data structure that
> describes the SH7786 controller.
> 
> The second patch fixes the driver for big-endian operation. However,
> I'd like this patch to be carefully reviewed by Sergei Shtylyov who
> already did some endianness related changes in this driver. Indeed, my
> change is based on the assumption that the DMA descriptors are in the
> native endianness of the CPU.

Sergei, please let me know when you've re-reviewed this series now
that you have documentation in hand...

Thanks.

      parent reply	other threads:[~2017-12-05 19:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 14:17 [PATCH 0/2] net: sh_eth: add support for SH7786 and big-endian Thomas Petazzoni
2017-12-04 14:17 ` [PATCH 1/2] net: sh_eth: add support for SH7786 Thomas Petazzoni
2017-12-04 16:56   ` Sergei Shtylyov
2017-12-04 17:06     ` Sergei Shtylyov
2017-12-05  7:49     ` Thomas Petazzoni
2017-12-05 19:04       ` Sergei Shtylyov
2017-12-05 19:49         ` Sergei Shtylyov
2017-12-05 20:14           ` David Miller
2017-12-08 15:40           ` Thomas Petazzoni
2017-12-10 11:55             ` Sergei Shtylyov
2017-12-05 10:42     ` Geert Uytterhoeven
2017-12-10 12:20   ` Sergei Shtylyov
2017-12-10 12:41     ` Sergei Shtylyov
2017-12-10 12:46     ` Sergei Shtylyov
2017-12-04 14:17 ` [PATCH 2/2] net: sh_eth: make work on big endian systems Thomas Petazzoni
2017-12-04 16:39   ` Sergei Shtylyov
2017-12-05 19:44 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171205.144405.531451693140949867.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=geert+renesas@glider.be \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).