From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/5] net: dsa: use per-port upstream port Date: Tue, 05 Dec 2017 14:47:27 -0500 (EST) Message-ID: <20171205.144727.522098543209254657.davem@davemloft.net> References: <20171204173457.14873-1-vivien.didelot@savoirfairelinux.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch To: vivien.didelot@savoirfairelinux.com Return-path: In-Reply-To: <20171204173457.14873-1-vivien.didelot@savoirfairelinux.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Vivien Didelot Date: Mon, 4 Dec 2017 12:34:52 -0500 > An upstream port is a local switch port used to reach a CPU port. > > DSA still considers a unique CPU port in the whole switch fabric and > thus return a unique upstream port for a given switch. This is wrong in > a multiple CPU ports environment. > > We are now switching to using the dedicated CPU port assigned to each > port in order to get rid of the deprecated unique tree CPU port. > > This patchset makes the dsa_upstream_port() helper take a port argument > and goes one step closer complete support for multiple CPU ports. Please adhere to reverse-christmas-tree for variable declarations in these changes. I know it can be a pain when there are inter-variable dependencies wrt. assignments, but just move it below the declaration and into a real statement. Thanks.