* [net 1/1] tipc: fix memory leak in tipc_accept_from_sock()
@ 2017-12-04 21:00 Jon Maloy
2017-12-05 19:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jon Maloy @ 2017-12-04 21:00 UTC (permalink / raw)
To: davem, netdev
Cc: tipc-discussion, hoang.h.le, mohan.krishna.ghanta.krishnamurthy
When the function tipc_accept_from_sock() fails to create an instance of
struct tipc_subscriber it omits to free the already created instance of
struct tipc_conn instance before it returns.
We fix that with this commit.
Reported-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
---
net/tipc/server.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/server.c b/net/tipc/server.c
index acaef80..bcede09 100644
--- a/net/tipc/server.c
+++ b/net/tipc/server.c
@@ -314,6 +314,7 @@ static int tipc_accept_from_sock(struct tipc_conn *con)
newcon->usr_data = s->tipc_conn_new(newcon->conid);
if (!newcon->usr_data) {
sock_release(newsock);
+ conn_put(newcon);
return -ENOMEM;
}
--
2.1.4
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [net 1/1] tipc: fix memory leak in tipc_accept_from_sock()
2017-12-04 21:00 [net 1/1] tipc: fix memory leak in tipc_accept_from_sock() Jon Maloy
@ 2017-12-05 19:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-12-05 19:54 UTC (permalink / raw)
To: jon.maloy
Cc: netdev, mohan.krishna.ghanta.krishnamurthy, tung.q.nguyen,
hoang.h.le, canh.d.luu, ying.xue, tipc-discussion
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Mon, 4 Dec 2017 22:00:20 +0100
> When the function tipc_accept_from_sock() fails to create an instance of
> struct tipc_subscriber it omits to free the already created instance of
> struct tipc_conn instance before it returns.
>
> We fix that with this commit.
>
> Reported-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-05 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-04 21:00 [net 1/1] tipc: fix memory leak in tipc_accept_from_sock() Jon Maloy
2017-12-05 19:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).