From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: thomas.petazzoni@free-electrons.com,
niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be,
horms+renesas@verge.net.au, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] net: sh_eth: add support for SH7786
Date: Tue, 05 Dec 2017 15:14:03 -0500 (EST) [thread overview]
Message-ID: <20171205.151403.1813635509479339757.davem@davemloft.net> (raw)
In-Reply-To: <a35c703f-9546-d4b7-25c4-681726bcea92@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Tue, 5 Dec 2017 22:49:10 +0300
> On 12/05/2017 10:04 PM, Sergei Shtylyov wrote:
>
>>>>> This commit adds the sh_eth_cpu_data structure that describes the
>>>>> SH7786 variant of the IP.
>>>>
>>>> The manual seems to be unavailable, so I have to trust you. :-)
>>>
>>> Yes, sadly. However, if you tell me what to double check, I'd be happy
>>> to do so.
>> I have the manual now, will check against it...
>> DaveM, I'm retracting my ACK for the time being.
>
> Starting to look into the manual, the current patch is wrong. SH7786
> SoC was probably the 1st one to use what we thought was R-Car specific
> register layout. Definite NAK on this version.
Ok.
next prev parent reply other threads:[~2017-12-05 20:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 14:17 [PATCH 0/2] net: sh_eth: add support for SH7786 and big-endian Thomas Petazzoni
2017-12-04 14:17 ` [PATCH 1/2] net: sh_eth: add support for SH7786 Thomas Petazzoni
2017-12-04 16:56 ` Sergei Shtylyov
2017-12-04 17:06 ` Sergei Shtylyov
2017-12-05 7:49 ` Thomas Petazzoni
2017-12-05 19:04 ` Sergei Shtylyov
2017-12-05 19:49 ` Sergei Shtylyov
2017-12-05 20:14 ` David Miller [this message]
2017-12-08 15:40 ` Thomas Petazzoni
2017-12-10 11:55 ` Sergei Shtylyov
2017-12-05 10:42 ` Geert Uytterhoeven
2017-12-10 12:20 ` Sergei Shtylyov
2017-12-10 12:41 ` Sergei Shtylyov
2017-12-10 12:46 ` Sergei Shtylyov
2017-12-04 14:17 ` [PATCH 2/2] net: sh_eth: make work on big endian systems Thomas Petazzoni
2017-12-04 16:39 ` Sergei Shtylyov
2017-12-05 19:44 ` [PATCH 0/2] net: sh_eth: add support for SH7786 and big-endian David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205.151403.1813635509479339757.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).