From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2] net: sh_eth: add support for SH7786 Date: Tue, 05 Dec 2017 15:14:03 -0500 (EST) Message-ID: <20171205.151403.1813635509479339757.davem@davemloft.net> References: <20171205084945.384ea35e@windsurf.lan> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: thomas.petazzoni@free-electrons.com, niklas.soderlund+renesas@ragnatech.se, geert+renesas@glider.be, horms+renesas@verge.net.au, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org To: sergei.shtylyov@cogentembedded.com Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Sergei Shtylyov Date: Tue, 5 Dec 2017 22:49:10 +0300 > On 12/05/2017 10:04 PM, Sergei Shtylyov wrote: > >>>>> This commit adds the sh_eth_cpu_data structure that describes the >>>>> SH7786 variant of the IP. >>>> >>>> The manual seems to be unavailable, so I have to trust you. :-) >>> >>> Yes, sadly. However, if you tell me what to double check, I'd be happy >>> to do so. >> I have the manual now, will check against it... >> DaveM, I'm retracting my ACK for the time being. > > Starting to look into the manual, the current patch is wrong. SH7786 > SoC was probably the 1st one to use what we thought was R-Car specific > register layout. Definite NAK on this version. Ok.