From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [v1] brcmfmac: Avoid build error with make W=1 Date: Tue, 5 Dec 2017 09:55:02 +0000 (UTC) Message-ID: <20171205095502.E6B336087D@smtp.codeaurora.org> References: <20171123155704.44878-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, brcm80211-dev-list-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Shevchenko To: Andy Shevchenko Return-path: In-Reply-To: <20171123155704.44878-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Andy Shevchenko wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! > scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed > > Seems like something happened with W=1 and wrong kernel doc format. > As a quick fix remove dubious /** in the code. > > Signed-off-by: Andy Shevchenko > Acked-by: Arend van Spriel I'll queue this to v4.15. -- https://patchwork.kernel.org/patch/10073021/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches