From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Michael Chan <michael.chan@broadcom.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends
Date: Tue, 5 Dec 2017 13:33:40 +0100 [thread overview]
Message-ID: <20171205123340.3307-1-tbogendoerfer@suse.de> (raw)
bnxt driver spams logfiles with
[ 541.003065] bnxt_en 0000:5d:00.1 eth5: Link speed -1 no longer supported
if a direct attached cable (DAC) is plugged into the bnxt card and is
unplugged on the other side. This patch removes the code printing this
message, since it doesn't provide any useful information.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 8c1dd60eab6f..8a2319ed79dc 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -1701,18 +1701,9 @@ static int bnxt_async_event_process(struct bnxt *bp,
/* TODO CHIMP_FW: Define event id's for link change, error etc */
switch (event_id) {
case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE: {
- u32 data1 = le32_to_cpu(cmpl->event_data1);
- struct bnxt_link_info *link_info = &bp->link_info;
-
if (BNXT_VF(bp))
goto async_event_process_exit;
- if (data1 & 0x20000) {
- u16 fw_speed = link_info->force_link_speed;
- u32 speed = bnxt_fw_to_ethtool_speed(fw_speed);
- netdev_warn(bp->dev, "Link speed %d no longer supported\n",
- speed);
- }
set_bit(BNXT_LINK_SPEED_CHNG_SP_EVENT, &bp->sp_event);
/* fall thru */
}
--
2.12.3
next reply other threads:[~2017-12-05 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 12:33 Thomas Bogendoerfer [this message]
2017-12-06 18:49 ` [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends David Miller
2017-12-06 19:27 ` Michael Chan
2017-12-07 9:14 ` Thomas Bogendoerfer
2017-12-07 9:24 ` Michael Chan
2017-12-07 9:39 ` Thomas Bogendoerfer
2017-12-07 9:47 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205123340.3307-1-tbogendoerfer@suse.de \
--to=tbogendoerfer@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox