From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 net-next] netlink: optimize err assignment
Date: Tue, 5 Dec 2017 15:03:10 -0800
Message-ID: <20171205150310.41879699@xeon-e3>
References: <1512306654-17546-1-git-send-email-cugyly@163.com>
        <1512314409.19682.51.camel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: yuan linyu <cugyly@163.com>, netdev@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f67.google.com ([74.125.83.67]:33085 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752709AbdLEXDS (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 5 Dec 2017 18:03:18 -0500
Received: by mail-pg0-f67.google.com with SMTP id g7so1258208pgs.0
        for <netdev@vger.kernel.org>; Tue, 05 Dec 2017 15:03:18 -0800 (PST)
In-Reply-To: <1512314409.19682.51.camel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sun, 03 Dec 2017 07:20:09 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> On Sun, 2017-12-03 at 21:10 +0800, yuan linyu wrote:
> > From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> >=20
> > Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> > ---
> > v2: fix kbuild test warning
> > ---
> > =C2=A0net/netlink/af_netlink.c | 52 ++++++++++++++++++++----------------
> > ------------
> > =C2=A01 file changed, 22 insertions(+), 30 deletions(-)
> >  =20
>=20
> I see no reason why we should accept this code churn.
>=20
> This kind of change makes future fix backports harder.
>=20

I more worried about the possibility of latent bugs.
Humans aren't perfect at following all code paths