From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8 Date: Tue, 5 Dec 2017 16:59:40 -0800 Message-ID: <20171205165940.3a75e4c7@xeon-e3> References: <20171201110451.25392-1-leon@kernel.org> <20171201084807.0ccfcc86@xeon-e3> <20171202082833.GF8126@mtr-leonro.local> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/4_VbI5v+UDImUvt8R98bJ9u"; protocol="application/pgp-signature" Cc: netdev@vger.kernel.org, Riad Abo Raed , Guy Ergas To: Leon Romanovsky Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:39575 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbdLFA7t (ORCPT ); Tue, 5 Dec 2017 19:59:49 -0500 Received: by mail-pf0-f193.google.com with SMTP id l24so1510143pfj.6 for ; Tue, 05 Dec 2017 16:59:48 -0800 (PST) In-Reply-To: <20171202082833.GF8126@mtr-leonro.local> Sender: netdev-owner@vger.kernel.org List-ID: --Sig_/4_VbI5v+UDImUvt8R98bJ9u Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 2 Dec 2017 10:28:33 +0200 Leon Romanovsky wrote: > On Fri, Dec 01, 2017 at 08:48:07AM -0800, Stephen Hemminger wrote: > > On Fri, 1 Dec 2017 13:04:51 +0200 > > Leon Romanovsky wrote: > > =20 > > > From: Leon Romanovsky > > > > > > Add asm/posix_types.h header file to the list of needed includes, > > > because the headers files in RHEL 6.8 are too old and doesn't > > > have declaration of __kernel_long_t. > > > > > > In file included from ../include/uapi/linux/kernel.h:5, > > > from ../include/uapi/linux/netfilter/x_tables.h:4, > > > from ../include/xtables.h:20, > > > from em_ipset.c:26: > > > ../include/uapi/linux/sysinfo.h:9: error: expected specifier-qualifie= r-list before =E2=80=98__kernel_long_t=E2=80=99 > > > > > > Cc: Riad Abo Raed > > > Cc: Guy Ergas > > > Signed-off-by: Leon Romanovsky =20 > > > > I see the problem, but the solution of dragging in posix_types.h > > would be too much of a long term maintenance issue. > > All the headers in uapi are regularly generated from upstream > > kernel headers; I don't want to start making exceptions. > > > > Is it just the xtables stuff (which has always been problematic)? =20 >=20 > Yes, both failures are related to xtables. And this wass my naive approac= h to > solve first one, the second mentioned in the original commit log > (missing xtables-version.h) is more harder to fix. >=20 > Will it work if I test in configure script the existence of __kernel_long= _t > and fallback to xt-internal.h? >=20 > Thanks Why not just modify the part of the configure script that checks if xtables= build will work. It should fail if header files won't work. --Sig_/4_VbI5v+UDImUvt8R98bJ9u Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEn2/DRbBb5+dmuDyPgKd/YJXN5H4FAlonQPwACgkQgKd/YJXN 5H6wrxAAjnObV45kEU44ywuO2CAcqT/5AMEpasSzH60DZ31XqQJO8gVHX5qq6NnX PdTG9EpVJVem20oAEV46ViVVrGD9R2zcM9CfCINRvdFZc6gvvTMa+IDxvoVfWXbO CQH52bjk9lnseydsB9JEn+tQXbbU+eFob6xPiZFdHP+zBNRcKImsJ+ods8/XvKW7 IUnwV0HYy0xrhZe6OtizFnMQzNW85knfmV/Iag2wakrJ01xno72A6i4UTPNYxGR+ Cb8CtyE9iRfu9MFMhzRaslCmGE1PEgfQqrItOUUu0+O4sbRVMtZAML186HNBg7KN 6zjSzL052mlkt6E7PgzA74ARGfMzVW5Sa0kP6Wb89rb96HmNHIxzdil7y3Gt4dWf h5I3v6mS2MbSNHY6u0Kx9Xb6Fe0iLBVfqj8ZJV0b0EV/pH85AeUKt/W6hB7UQ0xF f07u4WLoy864XJ6AIHfTHsoGRPWl+M/7TBrVitFL/o12bcqSBYHkBSahgSOk76Y8 cHlfZO468SdsZHMGJ0N7jPXZF2AMCNiOLq4Z5I+8O1eSvsfjQdmcxXuHrZPx/SE+ DscE6ZfiLUN/f68BeqQPUFTIylS8tVOuYqDVPOyGZA4kHR50uHwf/pR9bTfvyg7f UWZO1HTIvpFNygpN8m/wtlktBfi8cXknWJvXRleXBKfQnX1bAMU= =omjK -----END PGP SIGNATURE----- --Sig_/4_VbI5v+UDImUvt8R98bJ9u--