From: Stephen Hemminger <stephen@networkplumber.org>
To: William Tu <u9012063@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 iproute2 net-next] gre6: add collect metadata support
Date: Tue, 5 Dec 2017 17:07:31 -0800 [thread overview]
Message-ID: <20171205170731.2460b1cf@xeon-e3> (raw)
In-Reply-To: <1512515437-20922-1-git-send-email-u9012063@gmail.com>
On Tue, 5 Dec 2017 15:10:37 -0800
William Tu <u9012063@gmail.com> wrote:
> diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> index a6a10e577b1f..eb04f887c940 100644
> --- a/man/man8/ip-link.8.in
> +++ b/man/man8/ip-link.8.in
> @@ -755,6 +755,8 @@ the following additional arguments are supported:
> .BI "dscp inherit"
> ] [
> .BI dev " PHYS_DEV "
> +] [
> +.RB external
> ]
>
> .in +8
> @@ -833,6 +835,10 @@ or
> .IR 00 ".." ff
> when tunneling non-IP packets. The default value is 00.
>
> +.sp
> +.RB external
> +- make this tunnel externally controlled (or not, which is the default).
> +
> .in -8
I don't have any direct involvement in offload, so would like some feedback
from others that are.
Not a big fan of opaque "metadata" what exactly does it mean?
Also "external" is already used to mean something else on other parts of
the link command. Also the option, and the value in JSON should be the same.
Please reconsider the naming and resubmit
The wording in the man page here could be better
next prev parent reply other threads:[~2017-12-06 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 23:10 [PATCH v2 iproute2 net-next] gre6: add collect metadata support William Tu
2017-12-06 1:07 ` Stephen Hemminger [this message]
2017-12-06 1:40 ` Daniel Borkmann
2017-12-07 16:43 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205170731.2460b1cf@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).