From: Andrew Lunn <andrew@lunn.ch>
To: Richard Leitner <dev@g0hl1n.net>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, fugang.duan@nxp.com,
f.fainelli@gmail.com, frowand.list@gmail.com,
davem@davemloft.net, geert+renesas@glider.be,
sergei.shtylyov@cogentembedded.com, baruch@tkos.co.il,
david.wu@rock-chips.com, lukma@denx.de, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
richard.leitner@skidata.com
Subject: Re: [PATCH net-next v3 1/4] phylib: Add device reset delay support
Date: Tue, 5 Dec 2017 18:28:52 +0100 [thread overview]
Message-ID: <20171205172852.GM12805@lunn.ch> (raw)
In-Reply-To: <20171205132600.13796-2-dev@g0hl1n.net>
Hi Richard
> +++ b/drivers/of/of_mdio.c
> @@ -77,6 +77,14 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio,
> if (of_property_read_bool(child, "broken-turn-around"))
> mdio->phy_ignore_ta_mask |= 1 << addr;
>
> + if (of_property_read_u32(child, "reset-delay-us",
> + &phy->mdio.reset_delay))
> + phy->mdio.reset_delay = 0;
> +
> + if (of_property_read_u32(child, "reset-post-delay-us",
> + &phy->mdio.reset_post_delay))
> + phy->mdio.reset_post_delay = 0;
of_property_read_u32() should not change the variable you pass to it,
if it does not find the property. So you can change this to:
phy->mdio.reset_delay = 0;
phy->mdio.reset_post_delay = 0;
of_property_read_u32(child, "reset-delay-us",
&phy->mdio.reset_delay);
of_property_read_u32(child, "reset-post-delay-us",
&phy->mdio.reset_post_delay);
Andrew
next prev parent reply other threads:[~2017-12-05 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 13:25 [PATCH net-next v3 0/4] net: fec: fix refclk enable for SMSC LAN8710/20 Richard Leitner
2017-12-05 13:25 ` [PATCH net-next v3 1/4] phylib: Add device reset delay support Richard Leitner
[not found] ` <20171205132600.13796-2-dev-M/VWbR8SM2SsTnJN9+BGXg@public.gmane.org>
2017-12-05 13:54 ` Geert Uytterhoeven
[not found] ` <CAMuHMdX70yuEfoDL+Y4TZ-6zjyW9BqvKOU6UxbHTKGNcgfGrow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-05 14:56 ` Richard Leitner
2017-12-05 17:28 ` Andrew Lunn [this message]
2017-12-05 18:06 ` Richard Leitner
2017-12-05 13:25 ` [PATCH net-next v3 2/4] phylib: add reset after clk enable support Richard Leitner
2017-12-05 17:34 ` Andrew Lunn
[not found] ` <20171205173407.GN12805-g2DYL2Zd6BY@public.gmane.org>
2017-12-05 18:08 ` Richard Leitner
2017-12-05 13:25 ` [PATCH net-next v3 3/4] net: phy: smsc: LAN8710/20: add PHY_RST_AFTER_CLK_EN flag Richard Leitner
[not found] ` <20171205132600.13796-4-dev-M/VWbR8SM2SsTnJN9+BGXg@public.gmane.org>
2017-12-05 17:35 ` Andrew Lunn
2017-12-05 13:26 ` [PATCH net-next v3 4/4] net: fec: add phy_reset_after_clk_enable() support Richard Leitner
[not found] ` <20171205132600.13796-5-dev-M/VWbR8SM2SsTnJN9+BGXg@public.gmane.org>
2017-12-06 1:50 ` Andy Duan
[not found] ` <DB6PR0401MB2264B5060F745CEB5405FFBCFF320-2mNvjAGDOPl4towakvZX7o3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-12-06 8:12 ` Richard Leitner
[not found] ` <1e7b3e7f-251d-4101-1441-702e891f2ca9-WcANXNA0UjBBDgjK7y7TUQ@public.gmane.org>
2017-12-06 8:41 ` Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205172852.GM12805@lunn.ch \
--to=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=dev@g0hl1n.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).