From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8 Date: Tue, 5 Dec 2017 17:33:25 -0800 Message-ID: <20171205173325.7245f907@xeon-e3> References: <20171201110451.25392-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, Leon Romanovsky , Riad Abo Raed , Guy Ergas To: Leon Romanovsky Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:34192 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275AbdLFBez (ORCPT ); Tue, 5 Dec 2017 20:34:55 -0500 Received: by mail-pl0-f65.google.com with SMTP id d21so3127pll.1 for ; Tue, 05 Dec 2017 17:34:54 -0800 (PST) In-Reply-To: <20171201110451.25392-1-leon@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 1 Dec 2017 13:04:51 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky >=20 > Add asm/posix_types.h header file to the list of needed includes, > because the headers files in RHEL 6.8 are too old and doesn't > have declaration of __kernel_long_t. >=20 > In file included from ../include/uapi/linux/kernel.h:5, > from ../include/uapi/linux/netfilter/x_tables.h:4, > from ../include/xtables.h:20, > from em_ipset.c:26: > ../include/uapi/linux/sysinfo.h:9: error: expected specifier-qualifier-li= st before =E2=80=98__kernel_long_t=E2=80=99 >=20 > Cc: Riad Abo Raed > Cc: Guy Ergas > Signed-off-by: Leon Romanovsky > --- > Stephen, > I don't know how to properly solve this type of errors and would like to > hear your guidance on it. >=20 > Should I simply add kernel file? Or maybe I need to add HAVE_xxx checks > to configure script to check __kernel_long_t existence and declare only > this type? >=20 > I also have another build error on RHEL 6.8 system and looking for a > solution. >=20 > In file included from em_ipset.c:26: > ../include/xtables.h:35:29: error: xtables-version.h: No such file or dir= ectory > make[1]: *** [em_ipset.o] Error 1 >=20 > The iptables-devel is iptables-devel-1.4.7-16.el6.x86_64 so check_xt() > success, but RH headers don't have xtable-version.h and the relevant defi= nes > are embedded in the main xtables.h header file. >=20 > Thanks > --- > include/uapi/asm/posix_types.h | 97 ++++++++++++++++++++++++++++++++++++= +++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 include/uapi/asm/posix_types.h >=20 > diff --git a/include/uapi/asm/posix_types.h b/include/uapi/asm/posix_type= s.h > new file mode 100644 > index 00000000..5e6ea22b > --- /dev/null > +++ b/include/uapi/asm/posix_types.h > @@ -0,0 +1,97 @@ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > +#ifndef __ASM_GENERIC_POSIX_TYPES_H > +#define __ASM_GENERIC_POSIX_TYPES_H > + > +#include > +/* > + * This file is generally used by user-level software, so you need to > + * be a little careful about namespace pollution etc. > + * > + * First the types that are often defined in different ways across > + * architectures, so that you can override them. > + */ > + > +#ifndef __kernel_long_t > +typedef long __kernel_long_t; > +typedef unsigned long __kernel_ulong_t; > +#endif > + > +#ifndef __kernel_ino_t > +typedef __kernel_ulong_t __kernel_ino_t; > +#endif > + > +#ifndef __kernel_mode_t > +typedef unsigned int __kernel_mode_t; > +#endif > + > +#ifndef __kernel_pid_t > +typedef int __kernel_pid_t; > +#endif > + > +#ifndef __kernel_ipc_pid_t > +typedef int __kernel_ipc_pid_t; > +#endif > + > +#ifndef __kernel_uid_t > +typedef unsigned int __kernel_uid_t; > +typedef unsigned int __kernel_gid_t; > +#endif > + > +#ifndef __kernel_suseconds_t > +typedef __kernel_long_t __kernel_suseconds_t; > +#endif > + > +#ifndef __kernel_daddr_t > +typedef int __kernel_daddr_t; > +#endif > + > +#ifndef __kernel_uid32_t > +typedef unsigned int __kernel_uid32_t; > +typedef unsigned int __kernel_gid32_t; > +#endif > + > +#ifndef __kernel_old_uid_t > +typedef __kernel_uid_t __kernel_old_uid_t; > +typedef __kernel_gid_t __kernel_old_gid_t; > +#endif > + > +#ifndef __kernel_old_dev_t > +typedef unsigned int __kernel_old_dev_t; > +#endif > + > +/* > + * Most 32 bit architectures use "unsigned int" size_t, > + * and all 64 bit architectures use "unsigned long" size_t. > + */ > +#ifndef __kernel_size_t > +#if __BITS_PER_LONG !=3D 64 > +typedef unsigned int __kernel_size_t; > +typedef int __kernel_ssize_t; > +typedef int __kernel_ptrdiff_t; > +#else > +typedef __kernel_ulong_t __kernel_size_t; > +typedef __kernel_long_t __kernel_ssize_t; > +typedef __kernel_long_t __kernel_ptrdiff_t; > +#endif > +#endif > + > +#ifndef __kernel_fsid_t > +typedef struct { > + int val[2]; > +} __kernel_fsid_t; > +#endif > + > +/* > + * anything below here should be completely generic > + */ > +typedef __kernel_long_t __kernel_off_t; > +typedef long long __kernel_loff_t; > +typedef __kernel_long_t __kernel_time_t; > +typedef __kernel_long_t __kernel_clock_t; > +typedef int __kernel_timer_t; > +typedef int __kernel_clockid_t; > +typedef char * __kernel_caddr_t; > +typedef unsigned short __kernel_uid16_t; > +typedef unsigned short __kernel_gid16_t; > + > +#endif /* __ASM_GENERIC_POSIX_TYPES_H */ > -- > 2.15.1 >=20 This isn't going to be supportable. The headers in uapi are updated by a script from kernel, and this version posix_types.h conflicts with what the kernel creates by make headers_install.