From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Zubkov <zubkov318@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ip route: broken logic when using default word and family not specified
Date: Tue, 5 Dec 2017 17:42:03 -0800 [thread overview]
Message-ID: <20171205174203.43dacd0a@xeon-e3> (raw)
In-Reply-To: <CABXn0zd5eRTyWnNtpmMpHY=dWxtzRSXKtqw3wov=W2hH8Hs0og@mail.gmail.com>
On Sat, 18 Nov 2017 17:56:32 +0100
Alexander Zubkov <zubkov318@gmail.com> wrote:
> I also opened earlier a ticket in bugzilla:
> https://bugzilla.kernel.org/show_bug.cgi?id=197899
> And Stephen Hemminger had couple of comments there which I want to argue:
>
> > $ ip route list default
> > Means list all routes in any address family (ie same as any)
> > but
> >
> > $ ip route list 0/0
> > Means list all routes for IPv4 default route.
>
> This is not correct, because first command do not show routes in any
> address family. Now it do so only when table 0 is specified, otherwise
> only IPv4 routes are showed. Here is the code from iproute.c:
>
> if (do_ipv6 == AF_UNSPEC && filter.tb)
> do_ipv6 = AF_INET;
>
> > It probably is worth a man page warning, but changing semantics
> > that have existed for many years is more likely to break some existing user.
>
> Yes, backward compatibility is a reason. But as I remember, that
> sematics already have changed earlier. Probably it was showing IPv4
> and IPv6 routes together without family specified - I do not remember
> exactly. And I have doubts that such feature could be lied on
> reliably.
> I as a end user would prefer to make the behaviour more consistent and
> without such excetptions. But of course there may be other opinions.
As a conservative maintainer, my preference is always to receive acknowledgments
from others before accepting something that may break existing users.
Backward compatibility is more important than the surprising result you discovered.
A confused new user is less of an issue than breaking some existing user
who may not even have contact back to network developers.
Since it has been that way for many years, waiting a couple of weeks for review
is not going to hurt anything.
next prev parent reply other threads:[~2017-12-06 1:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 13:12 [PATCH iproute2] ip route: broken logic when using default word and family not specified Alexander Zubkov
2017-11-18 16:56 ` Alexander Zubkov
2017-12-04 19:41 ` Alexander Zubkov
2017-12-06 1:42 ` Stephen Hemminger [this message]
2017-12-16 21:21 ` Stephen Hemminger
2017-12-17 11:09 ` [PATCH] iproute: "list/flush/save default" selected all of the routes Alexander Zubkov
2017-12-19 16:27 ` Stephen Hemminger
2017-12-17 12:06 ` [PATCH iproute2] ip route: broken logic when using default word and family not specified Alexander Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205174203.43dacd0a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=zubkov318@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).