From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command Date: Tue, 5 Dec 2017 23:26:40 +0100 Message-ID: <20171205222640.GA25752@lunn.ch> References: <1512507203-17693-1-git-send-email-scott.branden@broadcom.com> <1512507203-17693-4-git-send-email-scott.branden@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "John W. Linville" , BCM Kernel Feedback , Steve Lin , Michael Chan , netdev@vger.kernel.org, Paul Greenwalt , Stephen Hemminger To: Scott Branden Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:48390 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718AbdLEW0u (ORCPT ); Tue, 5 Dec 2017 17:26:50 -0500 Content-Disposition: inline In-Reply-To: <1512507203-17693-4-git-send-email-scott.branden@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote: > Add ETHTOOL_RESET support via --reset command. > > ie. ethtool --reset DEVNAME > > flagnames currently match the ETH_RESET_xxx names: > mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated,all [Snip] > +.B ethtool \-\-reset > +.I devname > +.BN flags > +.RB [ mgmt ] > +.RB [ irq ] > +.RB [ dma ] > +.RB [ filter ] > +.RB [ offload ] > +.RB [ mac ] > +.RB [ phy ] > +.RB [ ram ] > +.RB [ ap ] > +.RB [ dedicated ] > +.RB [ all ] Hi Scott Just a nick pick. You don't list ap above, which is kind of why you are doing this, if i remember correctly. Andrew