From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Date: Wed, 06 Dec 2017 14:00:46 -0500 (EST) Message-ID: <20171206.140046.1593939441488896213.davem@davemloft.net> References: <20171205143752.cymsw7fzlqn6ejeq@mwanda> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: michael.chan@broadcom.com, sathya.perla@broadcom.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: dan.carpenter@oracle.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:53548 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbdLFTAs (ORCPT ); Wed, 6 Dec 2017 14:00:48 -0500 In-Reply-To: <20171205143752.cymsw7fzlqn6ejeq@mwanda> Sender: netdev-owner@vger.kernel.org List-ID: From: Dan Carpenter Date: Tue, 5 Dec 2017 17:37:52 +0300 > Smatch warns that: > > drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() > error: uninitialized symbol 'rc'. > > "rc" is either uninitialized or set to zero here so we can just remove > the check. > > Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload") > Signed-off-by: Dan Carpenter Michael, please review. Thanks.