From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, sgoutham@cavium.com,
aleksey.makarov@auriga.com, edumazet@google.com
Subject: Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv4 pkts
Date: Wed, 06 Dec 2017 14:44:11 -0500 (EST) [thread overview]
Message-ID: <20171206.144411.1171967163638961803.davem@davemloft.net> (raw)
In-Reply-To: <20171206000450.20729-1-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Wed, 6 Dec 2017 01:04:50 +0100
> Offload IP header checksum to NIC.
>
> This fixes a previous patch which disabled checksum offloading
> for both IPv4 and IPv6 packets. So L3 checksum offload was
> getting disabled for IPv4 pkts. And HW is dropping these pkts
> for some reason.
>
> Without this patch, IPv4 TSO appears to be broken:
>
> WIthout this patch I get ~16kbyte/s, with patch close to 2mbyte/s
> when copying files via scp from test box to my home workstation.
>
> Looking at tcpdump on sender it looks like hardware drops IPv4 TSO skbs.
> This patch restores performance for me, ipv6 looks good too.
>
> Fixes: fa6d7cb5d76c ("net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts")
> Cc: Sunil Goutham <sgoutham@cavium.com>
> Cc: Aleksey Makarov <aleksey.makarov@auriga.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied and queued up for -stable, thanks Florian.
prev parent reply other threads:[~2017-12-06 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 0:04 [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv4 pkts Florian Westphal
2017-12-06 19:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206.144411.1171967163638961803.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aleksey.makarov@auriga.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).