From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv4 pkts Date: Wed, 06 Dec 2017 14:44:11 -0500 (EST) Message-ID: <20171206.144411.1171967163638961803.davem@davemloft.net> References: <20171206000450.20729-1-fw@strlen.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sgoutham@cavium.com, aleksey.makarov@auriga.com, edumazet@google.com To: fw@strlen.de Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54200 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbdLFToN (ORCPT ); Wed, 6 Dec 2017 14:44:13 -0500 In-Reply-To: <20171206000450.20729-1-fw@strlen.de> Sender: netdev-owner@vger.kernel.org List-ID: From: Florian Westphal Date: Wed, 6 Dec 2017 01:04:50 +0100 > Offload IP header checksum to NIC. > > This fixes a previous patch which disabled checksum offloading > for both IPv4 and IPv6 packets. So L3 checksum offload was > getting disabled for IPv4 pkts. And HW is dropping these pkts > for some reason. > > Without this patch, IPv4 TSO appears to be broken: > > WIthout this patch I get ~16kbyte/s, with patch close to 2mbyte/s > when copying files via scp from test box to my home workstation. > > Looking at tcpdump on sender it looks like hardware drops IPv4 TSO skbs. > This patch restores performance for me, ipv6 looks good too. > > Fixes: fa6d7cb5d76c ("net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts") > Cc: Sunil Goutham > Cc: Aleksey Makarov > Cc: Eric Dumazet > Signed-off-by: Florian Westphal Applied and queued up for -stable, thanks Florian.