From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf_mirred Date: Wed, 06 Dec 2017 14:51:46 -0500 (EST) Message-ID: <20171206.145146.1318629799200615292.davem@davemloft.net> References: <20171206001727.25731-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jiri@mellanox.com, jhs@mojatatu.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54320 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbdLFTvs (ORCPT ); Wed, 6 Dec 2017 14:51:48 -0500 In-Reply-To: <20171206001727.25731-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Tue, 5 Dec 2017 16:17:26 -0800 > tcfm_dev always points to the correct netdev and we already > hold a refcnt, so no need to use tcfm_ifindex to lookup again. > > If we would support moving target netdev across netns, using > pointer would be better than ifindex. > > This also fixes dumping obsolete ifindex, now after the > target device is gone we just dump 0 as ifindex. > > Cc: Jiri Pirko > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang Both act_mirred patches applied, thanks Cong.