From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, jasowang@redhat.com, willemb@google.com
Subject: Re: [PATCH net-next] tun: avoid unnecessary READ_ONCE in tun_net_xmit
Date: Wed, 06 Dec 2017 15:09:29 -0500 (EST) [thread overview]
Message-ID: <20171206.150929.1869136637774624730.davem@davemloft.net> (raw)
In-Reply-To: <20171206031117.86588-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Tue, 5 Dec 2017 22:11:17 -0500
> From: Willem de Bruijn <willemb@google.com>
>
> The statement no longer serves a purpose.
>
> Commit fa35864e0bb7 ("tuntap: Fix for a race in accessing numqueues")
> added the ACCESS_ONCE to avoid a race condition with skb_queue_len.
>
> Commit 436accebb530 ("tuntap: remove unnecessary sk_receive_queue
> length check during xmit") removed the affected skb_queue_len check.
>
> Commit 96f84061620c ("tun: add eBPF based queue selection method")
> split the function, reading the field a second time in the callee.
> The temp variable is now only read once, so just remove it.
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied, thanks Willem.
prev parent reply other threads:[~2017-12-06 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 3:11 [PATCH net-next] tun: avoid unnecessary READ_ONCE in tun_net_xmit Willem de Bruijn
2017-12-06 3:39 ` Jason Wang
2017-12-06 20:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206.150929.1869136637774624730.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox