From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH V2] netlink: Add netns check on taps
Date: Wed, 06 Dec 2017 15:57:14 -0500 (EST)
Message-ID: <20171206.155714.908446002721815545.davem@davemloft.net>
References: <1512591147-29618-1-git-send-email-cernekee@chromium.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: johannes.berg@intel.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, daniel@iogearbox.net,
        dsahern@gmail.com
To: cernekee@chromium.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:55278 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751500AbdLFU5Q (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 6 Dec 2017 15:57:16 -0500
In-Reply-To: <1512591147-29618-1-git-send-email-cernekee@chromium.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Kevin Cernekee <cernekee@chromium.org>
Date: Wed,  6 Dec 2017 12:12:27 -0800

> Currently, a nlmon link inside a child namespace can observe systemwide
> netlink activity.  Filter the traffic so that nlmon can only sniff
> netlink messages from its own netns.
> 
> Test case:
> 
>     vpnns -- bash -c "ip link add nlmon0 type nlmon; \
>                       ip link set nlmon0 up; \
>                       tcpdump -i nlmon0 -q -w /tmp/nlmon.pcap -U" &
>     sudo ip xfrm state add src 10.1.1.1 dst 10.1.1.2 proto esp \
>         spi 0x1 mode transport \
>         auth sha1 0x6162633132330000000000000000000000000000 \
>         enc aes 0x00000000000000000000000000000000
>     grep --binary abc123 /tmp/nlmon.pcap
> 
> Signed-off-by: Kevin Cernekee <cernekee@chromium.org>

Applied and queued up for -stable, thanks Kevin.