From: Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf_mirred
Date: Wed, 6 Dec 2017 09:33:48 +0100 [thread overview]
Message-ID: <20171206083348.GA1823@nanopsycho> (raw)
In-Reply-To: <20171206001727.25731-1-xiyou.wangcong@gmail.com>
Wed, Dec 06, 2017 at 01:17:26AM CET, xiyou.wangcong@gmail.com wrote:
>tcfm_dev always points to the correct netdev and we already
>hold a refcnt, so no need to use tcfm_ifindex to lookup again.
>
>If we would support moving target netdev across netns, using
>pointer would be better than ifindex.
>
>This also fixes dumping obsolete ifindex, now after the
>target device is gone we just dump 0 as ifindex.
>
>Cc: Jiri Pirko <jiri@mellanox.com>
>Cc: Jamal Hadi Salim <jhs@mojatatu.com>
>Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks!
next prev parent reply other threads:[~2017-12-06 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 0:17 [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf_mirred Cong Wang
2017-12-06 0:17 ` [Patch net-next v2] act_mirred: get rid of mirred_list_lock spinlock Cong Wang
2017-12-06 8:35 ` Jiri Pirko
2017-12-06 8:33 ` Jiri Pirko [this message]
2017-12-06 19:51 ` [Patch net-next v2] act_mirred: get rid of tcfm_ifindex from struct tcf_mirred David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206083348.GA1823@nanopsycho \
--to=jiri@resnulli.us \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).