From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: ethtool-copy.h out of sync with linux header file? Date: Wed, 6 Dec 2017 09:19:50 -0500 Message-ID: <20171206141950.GA1271@tuxdriver.com> References: <9A83C569D64F2541B0B591F2CBA3CC01CB2CE496@ORSMSX112.amr.corp.intel.com> <418b362a-6a77-1fd8-9df8-056f55cc8f55@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: "Greenwalt, Paul" , netdev To: Scott Branden Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:39600 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbdLFOaV (ORCPT ); Wed, 6 Dec 2017 09:30:21 -0500 Content-Disposition: inline In-Reply-To: <418b362a-6a77-1fd8-9df8-056f55cc8f55@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Dec 05, 2017 at 12:25:51PM -0800, Scott Branden wrote: > Hi Paul, > > > On 17-12-04 01:00 PM, Greenwalt, Paul wrote: > > John, > > > > Can this patch be reverted? As Stephen Hemminger mentioned > > there is an ABI compatibility issue with this patch: > I can add the revert into a patch series followed by the sync of > ethtool-copy.h with net-netx ethtool.h Yes, exactly. I see that you did just that in your later series submission. Thanks! John > > > > https://patchwork.ozlabs.org/patch/806049/#1757846 > > > > Thanks, > > Paul > > > > > -----Original Message----- > > > From: Scott Branden [mailto:scott.branden@broadcom.com] > > > Sent: Monday, December 4, 2017 12:07 PM > > > To: linville@tuxdriver.com; Greenwalt, Paul > > > Cc: netdev > > > Subject: ethtool-copy.h out of sync with linux header file? > > > > > > Hi Paul/John, > > > > > > I see a commit "ethtool: Add DMA Coalescing support" was added to > > > ethtool-copy.h yet I cannot find the change in the ethtool.h in the > > > linux kernel. > > > > > > As such, I am unable to commit a change to ethtool-copy.h to sync it > > > with net-next.  If I sync then ethtool will fail to compile. > > > > > > Please advise. > > > > > > Thanks, > > > > > >  Scott > > > > > > > > -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.