From: David Miller <davem@davemloft.net>
To: branislav@radocaj.org
Cc: heiko@sntech.de, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe
Date: Thu, 07 Dec 2017 13:52:07 -0500 (EST) [thread overview]
Message-ID: <20171207.135207.212566260948460919.davem@davemloft.net> (raw)
In-Reply-To: <20171206230738.2560-1-branislav@radocaj.org>
From: Branislav Radocaj <branislav@radocaj.org>
Date: Thu, 7 Dec 2017 00:07:38 +0100
> If clk_set_rate() fails, we should disable clk before return.
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Branislav Radocaj <branislav@radocaj.org>
Ok, but this probe routine is very inconsistent in how it handles
clock rate setting failures now.
Above your changes, if the RGMII clk can't have it's rate set, we
just continue.
next prev parent reply other threads:[~2017-12-07 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 23:07 [PATCH] net: ethernet: arc: fix error handling in emac_rockchip_probe Branislav Radocaj
2017-12-07 18:52 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-06 17:24 Branislav Radocaj
2017-12-06 20:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207.135207.212566260948460919.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=branislav@radocaj.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox