From: David Miller <davem@davemloft.net>
To: aleksey.makarov@cavium.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sunil.Goutham@cavium.com,
rad@semihalf.com, rric@kernel.org, ddaney@caviumnetworks.com
Subject: Re: [PATCH net-next v3 0/2] net: thunderx: add support for PTP clock
Date: Thu, 07 Dec 2017 14:14:14 -0500 (EST) [thread overview]
Message-ID: <20171207.141414.1589365570542864289.davem@davemloft.net> (raw)
In-Reply-To: <20171207.133932.904724095727636711.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 07 Dec 2017 13:39:32 -0500 (EST)
> From: Aleksey Makarov <aleksey.makarov@cavium.com>
> Date: Wed, 6 Dec 2017 16:30:56 +0300
>
>> This series adds support for IEEE 1588 Precision Time Protocol
>> to Cavium ethernet driver.
>
> Series applied, thank you.
Actually, this doesn't even compile, I'm reverting:
drivers/net/ethernet/cavium/common/cavium_ptp.c:64:20: error: redefinition of ‘cavium_ptp_get’
struct cavium_ptp *cavium_ptp_get(void)
^~~~~~~~~~~~~~
In file included from drivers/net/ethernet/cavium/common/cavium_ptp.c:19:0:
drivers/net/ethernet/cavium/common/cavium_ptp.h:59:34: note: previous definition of ‘cavium_ptp_get’ was here
static inline struct cavium_ptp *cavium_ptp_get(void)
^~~~~~~~~~~~~~
drivers/net/ethernet/cavium/common/cavium_ptp.c:84:6: error: redefinition of ‘cavium_ptp_put’
void cavium_ptp_put(struct cavium_ptp *ptp)
^~~~~~~~~~~~~~
In file included from drivers/net/ethernet/cavium/common/cavium_ptp.c:19:0:
drivers/net/ethernet/cavium/common/cavium_ptp.h:64:20: note: previous definition of ‘cavium_ptp_put’ was here
static inline void cavium_ptp_put(struct cavium_ptp *ptp) {}
^~~~~~~~~~~~~~
next prev parent reply other threads:[~2017-12-07 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 13:30 [PATCH net-next v3 0/2] net: thunderx: add support for PTP clock Aleksey Makarov
2017-12-06 13:30 ` [PATCH net-next v3 1/2] net: add support for Cavium PTP coprocessor Aleksey Makarov
2017-12-06 13:30 ` [PATCH net-next v3 2/2] net: thunderx: add timestamping support Aleksey Makarov
2017-12-07 18:39 ` [PATCH net-next v3 0/2] net: thunderx: add support for PTP clock David Miller
2017-12-07 19:14 ` David Miller [this message]
2017-12-07 23:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207.141414.1589365570542864289.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Sunil.Goutham@cavium.com \
--cc=aleksey.makarov@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rad@semihalf.com \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox