From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 2/4] net: aquantia: Fix hardware DMA stream overload on large MRRS Date: Thu, 07 Dec 2017 14:23:31 -0500 (EST) Message-ID: <20171207.142331.906125407031062563.davem@davemloft.net> References: <5e0faf4821c3d01d1de296da18f6c07877223c4f.1512548097.git.igor.russkikh@aquantia.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, darcari@redhat.com, pavel.belous@aquantia.com, Nadezhda.Krupnina@aquantia.com, simon.edelhaus@aquantia.com To: igor.russkikh@aquantia.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:42842 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdLGTXd (ORCPT ); Thu, 7 Dec 2017 14:23:33 -0500 In-Reply-To: <5e0faf4821c3d01d1de296da18f6c07877223c4f.1512548097.git.igor.russkikh@aquantia.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Igor Russkikh Date: Thu, 7 Dec 2017 11:39:43 +0300 > @@ -2343,6 +2343,9 @@ > #define tx_dma_desc_base_addrmsw_adr(descriptor) \ > (0x00007c04u + (descriptor) * 0x40) > > +/* tx dma total request limit */ > +#define tx_dma_total_req_limit_adr 0x00007b20u > + > /* tx interrupt moderation control register definitions > * Preprocessor definitions for TX Interrupt Moderation Control Register > * Base Address: 0x00008980 > @@ -2369,6 +2372,9 @@ > /* default value of bitfield reg_res_dsbl */ > #define pci_reg_res_dsbl_default 0x1 > > +/* PCI core control register */ > +#define pci_reg_control6_adr 0x1014u > + I should have given you this feedback a long time ago, but better late than never... CPP macros, especially those which define register numbers or bit valus, should never use lowercase. They should always use uppercase names. This is a coding style convention we use in the entire kernel which makes it easy to visually see whether something is a bonafide C symbol or a CPP macro. Thank you.