From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] usbnet: fix alignment for frames with no ethernet header Date: Thu, 07 Dec 2017 14:33:19 -0500 (EST) Message-ID: <20171207.143319.2108953933463684291.davem@davemloft.net> References: <20171206192124.21670-1-bjorn@mork.no> <20171206.155611.1757498962538253791.davem@davemloft.net> <87y3mepdkz.fsf@miraculix.mork.no> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Cc: netdev@vger.kernel.org, jay@systech.com, linux-usb@vger.kernel.org, oneukum@suse.com To: bjorn@mork.no Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:43008 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdLGTdV (ORCPT ); Thu, 7 Dec 2017 14:33:21 -0500 In-Reply-To: <87y3mepdkz.fsf@miraculix.mork.no> Sender: netdev-owner@vger.kernel.org List-ID: From: Bjørn Mork Date: Thu, 07 Dec 2017 20:01:16 +0100 > David Miller writes: > >> From: Bjørn Mork >> Date: Wed, 6 Dec 2017 20:21:24 +0100 >> >>> The qmi_wwan minidriver support a 'raw-ip' mode where frames are >>> received without any ethernet header. This causes alignment issues >>> because the skbs allocated by usbnet are "IP aligned". >>> >>> Fix by allowing minidrivers to disable the additional alignment >>> offset. This is implemented using a per-device flag, since the same >>> minidriver also supports 'ethernet' mode. >>> >>> Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode") >>> Reported-and-tested-by: Jay Foster >>> Signed-off-by: Bjørn Mork >> >> Looks good, applied and queued up for -stable. > > > Thanks. I can see it in the -stable queue, but it didn't show up here > yet: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git > > Did it get stuck somewhere? Caught again :-) I do GIT work on two different machines (one at home and one at the office) and sometimes I head to the office before pushing everything out on the machine at home :-/ I've pushed this specific patch out to 'net'.