From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH net 1/2] bpf/verifier: fix bounds calculation on BPF_RSH
Date: Wed, 6 Dec 2017 17:47:45 -0800
Message-ID: <20171207014743.tzgdme4j2wv5rysg@ast-mbp>
References: <7c4a1470-3cf1-ceae-c99f-6591f1882063@solarflare.com>
 <f5041e0a-85d9-6b14-a052-59bae94a5f63@solarflare.com>
 <20171205194413.opdsw3muh2b7ujw5@ast-mbp.dhcp.thefacebook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: davem <davem@davemloft.net>, netdev@vger.kernel.org,
        Jann Horn <jannh@google.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
To: Edward Cree <ecree@solarflare.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f195.google.com ([209.85.192.195]:46319 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751718AbdLGBrs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 6 Dec 2017 20:47:48 -0500
Received: by mail-pf0-f195.google.com with SMTP id c204so3446479pfc.13
        for <netdev@vger.kernel.org>; Wed, 06 Dec 2017 17:47:48 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20171205194413.opdsw3muh2b7ujw5@ast-mbp.dhcp.thefacebook.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Dec 05, 2017 at 11:44:14AM -0800, Alexei Starovoitov wrote:
> On Tue, Dec 05, 2017 at 07:15:18PM +0000, Edward Cree wrote:
> > Incorrect signed bounds were being computed, although this had no effect
> >  since the propagation in __reg_deduce_bounds() happened to overwrite them.
> > 
> > Fixes: b03c9f9fdc37 ("bpf/verifier: track signed and unsigned min/max values")
> > Reported-by: Jann Horn <jannh@google.com>
> > Signed-off-by: Edward Cree <ecree@solarflare.com>
> 
> Acked-by: Alexei Starovoitov <ast@kernel.org>

turned out this one is incomplete fix. The more complete set
from Jann and Ed will be coming.