From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH net v2] adding missing rcu_read_unlock in ipxip6_rcv
Date: Wed, 6 Dec 2017 17:54:24 -0800
Message-ID: <20171207015422.xuskvzk7mczzjg3d@ast-mbp>
References: <20171207011543.2877447-1-tehnerd@fb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev <netdev@vger.kernel.org>, ast@kernel.org,
        vnuorval@tcs.hut.fi, Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>
To: "Nikita V. Shirokov" <tehnerd@fb.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f51.google.com ([74.125.83.51]:37077 "EHLO
        mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752059AbdLGBy1 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 6 Dec 2017 20:54:27 -0500
Received: by mail-pg0-f51.google.com with SMTP id y6so3338806pgp.4
        for <netdev@vger.kernel.org>; Wed, 06 Dec 2017 17:54:27 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20171207011543.2877447-1-tehnerd@fb.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Dec 06, 2017 at 05:15:43PM -0800, Nikita V. Shirokov wrote:
> commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")
> introduced new exit point in  ipxip6_rcv. however rcu_read_unlock is
> missing there. this diff is fixing this
> 
> v1->v2:
>  instead of doing rcu_read_unlock in place, we are going to "drop"
>  section (to prevent skb leakage)
> 
> Signed-off-by: Nikita V. Shirokov <tehnerd@fb.com>

thanks for fixing my mess.
Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")
Acked-by: Alexei Starovoitov <ast@kernel.org>