From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, Arnd Bergmann <arnd@arndb.de>,
Johannes Berg <johannes.berg@intel.com>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
Iain Hunter <drhunter95@gmail.com>, "Reizer, Eyal" <eyalr@ti.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: wlcore: use boottime for fw time sync
Date: Thu, 7 Dec 2017 13:20:46 +0000 (UTC) [thread overview]
Message-ID: <20171207132047.9770D6086A@smtp.codeaurora.org> (raw)
In-Reply-To: <20171127114903.2779545-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> Using getnstimeofday()/timespec_to_ns() causes an overflow on 32-bit
> architectures in 2038, and may suffer from time jumps due to
> settimeofday() or leap seconds.
>
> I don't see a reason why this needs to be UTC, so either monotonic
> or boot time would be better here. Assuming that the fw time keeps
> running during suspend, boottime is better than monotonic, and
> ktime_get_boot_ns() will also save the additional conversion to
> nanoseconds.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied to wireless-drivers-next.git, thanks.
99f6996d4cba wlcore: use boottime for fw time sync
--
https://patchwork.kernel.org/patch/10076691/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-12-07 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 11:48 [PATCH] wlcore: use boottime for fw time sync Arnd Bergmann
2017-12-07 13:20 ` Kalle Valo [this message]
2017-12-07 13:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207132047.9770D6086A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=drhunter95@gmail.com \
--cc=eyalr@ti.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).