From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next] netdevsim: remove check on return value of debugfs_create_dir Date: Thu, 7 Dec 2017 18:47:31 -0800 Message-ID: <20171207184731.6cf46b50@cakuba.netronome.com> References: <20171208021456.3392-1-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , netdev@vger.kernel.org To: Prashant Bhole Return-path: Received: from mail-qt0-f196.google.com ([209.85.216.196]:43217 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbdLHCrg (ORCPT ); Thu, 7 Dec 2017 21:47:36 -0500 Received: by mail-qt0-f196.google.com with SMTP id w10so22872395qtb.10 for ; Thu, 07 Dec 2017 18:47:35 -0800 (PST) In-Reply-To: <20171208021456.3392-1-bhole_prashant_q7@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 8 Dec 2017 11:14:56 +0900, Prashant Bhole wrote: > Initial discussion started about correct handling of this condition. > Later it was decided to remove this check altogether to make it > consistent. > > Removal of this check isn't fatal to this driver. > > Signed-off-by: Prashant Bhole Acked-by: Jakub Kicinski but as I mentioned there is another, similar check in netdevsim/bpf.c: "... drop this error handling here and in nsim_bpf_create_prog()." > diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c > index eb8c679fca9f..6d4b35f26ae5 100644 > --- a/drivers/net/netdevsim/netdev.c > +++ b/drivers/net/netdevsim/netdev.c > @@ -469,8 +469,6 @@ static int __init nsim_module_init(void) > int err; > > nsim_ddir = debugfs_create_dir(DRV_NAME, NULL); > - if (IS_ERR(nsim_ddir)) > - return PTR_ERR(nsim_ddir); > > err = bus_register(&nsim_bus); > if (err)