From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <igor.russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, David Arcari <darcari@redhat.com>,
Pavel Belous <pavel.belous@aquantia.com>,
Nadezhda Krupnina <Nadezhda.Krupnina@aquantia.com>,
Simon Edelhaus <simon.edelhaus@aquantia.com>
Subject: Re: [PATCH net 3/4] net: aquantia: Improve and fix statistics on device
Date: Thu, 7 Dec 2017 20:08:30 +0100 [thread overview]
Message-ID: <20171207190830.GB7240@lunn.ch> (raw)
In-Reply-To: <8ceab59934125ad4eb56aa304a14b5f90378e115.1512548097.git.igor.russkikh@aquantia.com>
On Thu, Dec 07, 2017 at 11:39:44AM +0300, Igor Russkikh wrote:
> 1) Device hardware provides only 32bit counters. Using these directly
> causes byte counters to overflow soon. A separate nic level structure
> with 64 bit counters is now used to collect incrementally all the stats
> and report these counters to ethtool stats and ndev stats.
>
> 2) ndev stats were filled from ring counters. These sometimes incorrectly
> calculate byte and packet amounts when using LRO/LSO and jumboframes.
> Fill ndev counters from hardware makes them precise.
>
> 3) Fill in multicast counter in ndev stats from hardware counter
>
> 4) Improve link state and statistics check interval callback: reduce normal
> timeout from 2 secs to 1 sec. If link is down, reduce it to 500msec. This
> speeds up link detection.
>
> 5) Reset driver level statistics to zero on initialization
>
> 6) Fix typo in ethtool statistics names
Hi Igor
This list suggests there should actually be 6 patches, not one.
Andrew
next prev parent reply other threads:[~2017-12-07 19:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 8:39 [PATCH net 0/4] net: aquantia: Atlantic driver 12/2017 updates Igor Russkikh
2017-12-07 8:39 ` [PATCH net 1/4] net: aquantia: Fix actual speed capabilities reporting Igor Russkikh
2017-12-07 8:39 ` [PATCH net 2/4] net: aquantia: Fix hardware DMA stream overload on large MRRS Igor Russkikh
2017-12-07 19:23 ` David Miller
2017-12-08 9:56 ` Igor Russkikh
2017-12-07 8:39 ` [PATCH net 3/4] net: aquantia: Improve and fix statistics on device Igor Russkikh
2017-12-07 19:08 ` Andrew Lunn [this message]
2017-12-08 9:43 ` Igor Russkikh
2017-12-07 8:39 ` [PATCH net 4/4] net: atlantic: Increment driver version Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207190830.GB7240@lunn.ch \
--to=andrew@lunn.ch \
--cc=Nadezhda.Krupnina@aquantia.com \
--cc=darcari@redhat.com \
--cc=davem@davemloft.net \
--cc=igor.russkikh@aquantia.com \
--cc=netdev@vger.kernel.org \
--cc=pavel.belous@aquantia.com \
--cc=simon.edelhaus@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).